Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(store): allow primitive types #2967

Merged
merged 3 commits into from
Mar 12, 2021
Merged

fix(store): allow primitive types #2967

merged 3 commits into from
Mar 12, 2021

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #2966

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ngrxbot
Copy link
Collaborator

ngrxbot commented Mar 10, 2021 •
edited
Loading

Preview docs changes for 7eb97b1 at https://previews.ngrx.io/pr2967-7eb97b15/

@brandonroberts brandonroberts merged commit eecc8ce into master Mar 12, 2021
@brandonroberts brandonroberts deleted the create-reducer-primitive-types branch March 12, 2021 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonroberts brandonroberts brandonroberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inferred generic type of reducers Number/String/Boolean instead of number/string/boolean
3 participants
@timdeschryver @ngrxbot @brandonroberts